Ticket #997 (closed task: fixed)

Opened 8 years ago

Last modified 7 years ago

Convert JHotDrawOverlayAdapter annotation to a Plugin type

Reported by: curtis Owned by: curtis
Priority: minor Milestone: imagej2-b4-plugins
Component: Plugin Framework Version:
Severity: minor Keywords:
Cc: Blocked By:
Blocking: #993, #1052

Description

As part of the effort to standardize discovered elements to use ImageJ's Plugin whenever possible, the JHotDrawOverlayAdapter SezPoz annotation could use the Plugin annotation instead, as a new type of IPlugin. The main obstacle here is that some classes are annotated with both JHotDrawOverlayAdapter and Tool, and it is not possible to have multiple Plugin annotations on the same class. So we need to find a way around this.

Change History

comment:1 Changed 8 years ago by curtis

  • Component changed from ij-tools to ij-ext

comment:2 Changed 8 years ago by curtis

  • Blocking 1052 added

comment:3 Changed 7 years ago by curtis

  • Blocking 993 added

comment:4 Changed 7 years ago by curtis

The requirement for two separate annotations (JHotDrawOverlayAdapter and Tool) is easily solved by making the IJHotDrawOverlayAdapter class a subinterface of imagej.ext.tool.Tool. The former interface has no methods apart from a priority() which @Plugins already have anyway.

comment:5 Changed 7 years ago by curtis

I completed initial work on this ticket on the  jhotdraw-tools branch, with the most telling commit being 183062e0. We'll merge to master soon, pending code review.

comment:6 Changed 7 years ago by curtis

  • Status changed from new to accepted

comment:7 Changed 7 years ago by curtis

  • Status changed from accepted to closed
  • Resolution set to fixed

Merged to master in 75070c55.

Note: See TracTickets for help on using tickets.