Ticket #988 (closed defect: wontfix)

Opened 6 years ago

Last modified 3 years ago

More intelligent syncing between ShadowMenu and UI-specific menus

Reported by: curtis Owned by: curtis
Priority: minor Milestone: imagej2-unscheduled
Component: UI Framework Version:
Severity: minor Keywords:
Cc: Blocked By:
Blocking: #985, #1630

Description

Currently, when a ShadowMenu change and fires a subclass of MenuEvent, the UIService intercepts the event and does a total rebuild of the UI's menu by calling UserInterface.createMenus() again. While this works, it is certainly overkill and may have performance implications when menu changes happen rapidly.

Better would be expand the MenuCreator class hierarchy to support surgical updates to UI-specific menu structures. The "MenuCreator" would become more of a "MenuSyncer" and would bidirectionally unite the UI-specific menu with its linked ShadowMenu.

Change History

comment:1 Changed 6 years ago by curtis

Also, this change will solve an issue discussed on the mailing list:

 http://imagej.net/pipermail/imagej-devel/2012-February/000571.html

comment:2 Changed 6 years ago by dscho

Maybe I should have commented here instead on bug 985? (I'm referring to  http://code.imagej.net/trac/imagej/ticket/985#comment:1)

comment:3 Changed 6 years ago by curtis

  • Blocking 985 added

(In #985) Solving #988 will probably be sufficient to fully address this ticket as well, though testing will be needed.

comment:4 Changed 6 years ago by curtis

  • Milestone changed from imagej-2.0-beta3 to imagej-2.0-beta2

Moving to beta2, to match ticket #985.

comment:5 Changed 6 years ago by curtis

  • Blocking 1162 added

comment:6 Changed 5 years ago by curtis

  • Blocking 1291 added; 1162 removed
  • Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta4

comment:7 Changed 5 years ago by bdezonia

  • Blocking 1289 added

comment:8 Changed 5 years ago by bdezonia

  • Blocking 1289 removed

comment:9 Changed 5 years ago by curtis

  • Blocking 1356 added

comment:10 Changed 5 years ago by curtis

  • Blocking 1291 removed

(In #1291) Pushing some menuing tickets to 2.0.0-beta5; see #1356.

comment:11 Changed 5 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta5

comment:12 Changed 5 years ago by bdezonia

  • Blocking 1630 added; 1356 removed
  • Milestone changed from imagej2-b7-ndim-data to imagej2-unscheduled

comment:13 Changed 3 years ago by curtis

  • Status changed from new to closed
  • Resolution set to wontfix

Punting on this for now. We can tackle it later, only as needed.

Note: See TracTickets for help on using tickets.