Ticket #915 (closed defect: fixed)

Opened 8 years ago

Last modified 7 years ago

ColorTableHarmonizer needs to be updated

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b4-plugins
Component: Legacy Compatibility Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1340

Description

ColorTableHarmonization works on a DatasetView rather than a Dataset. Thus it bypasses the Dataset::update() mechanism which is responsible for generating redraws. So LUTs might not get applied to the view correctly. This is manifested when Harmonizer::updateDataset() does not, by default, do a ds.update(). In the case of loading blobs it will then display as mostly black (when the correct behavior is as mostly white).

To avoid doing a direct redraw in the ColorTableHarmonizer we need it to generate some kind of update request that gets handled later. This should happen when the display update event handling logic is changed.

I have tagged Harmonizer and ColorTableHarmonizer with TODOs marking the needed changes when the display event handling mechanism is changed.

Change History

comment:1 Changed 7 years ago by bdezonia

  • Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta4

comment:2 Changed 7 years ago by bdezonia

  • Blocking 1340 added

comment:3 Changed 7 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed

Testing shortly before beta 4 and the workaround in Marmonizer no longer seems necessary. The display update changes happened long ago. With commit 6a82c4d6b09881899672a728df400fde002b5666 I have disabled the workaround in Harmonizer but left the comment in place in case we need to reenable it.

Note: See TracTickets for help on using tickets.