Ticket #872 (closed task: fixed)

Opened 8 years ago

Last modified 8 years ago

Add better overlay defaults behavior

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b1-initial
Component: Plugins Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking:

Description

IJ1 make the Overlay Options dialog set defaults and apply changes to the current selection. Break out this behavior into two dialogs. One for setting defaults and one for updating existing rois. Maybe make the second one have a button that says "make these the default settings". Think about this more. Currently IJ2 has Overlay Properties with no defaulting behavior and IJ1 has Overlay Options which does both tasks. Extending IJ2's version to have both concerns causes some hacky dependency issues.

Change History

comment:1 Changed 8 years ago by bdezonia

Have a partial implementation on my machine. Need to test that it works before committing. And deal with the default fill color issue documented in OptionsSynchronizer.

comment:2 Changed 8 years ago by bdezonia

All known bugs fixed by af78c59989cf211e15c1709b01baa3babae3e3db, 60bbfd36419cbc799dad1f9394e723a417bface6, 42040bfb4e78498f24a059eef907169f49168dea, 0d0a1fa895781e87996c2ff5283ff29630aa6d95, and 1d68895188fe6796ab5beb64fe88b2c5366d08e8.

TODO - make sure any tool that creates a ROI uses the default attributes set in Edit :: Options :: Overlay.

comment:3 Changed 8 years ago by bdezonia

Opened previous TODO as separate ticket: #874

TODO - current implementation has returned behavior of being unable to specify a fill color that is reflected in IJ1's Overlay Options plugin. And gets set back to none after running the plugin.

TODO - it might be best to relocate OptionsOverlay plugin to same menu position as IJ1.

TODO - is it possible to combine Overlay Properties and the OverlayOptions dialogs in a fashion similar to IJ1?

comment:4 Changed 8 years ago by bdezonia

In 216d92ad06ff9290857388b50415fc34913ef5cf fixed fill color to none bug

comment:5 Changed 8 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed

Relocated in menu tree to Image :: Overlay :: Overlay Options

Decided to leave the two dialog solution.

Note: See TracTickets for help on using tickets.