Ticket #824 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Improve error handling by LegacyPlugin when given an incompatible Dataset

Reported by: bdezonia Owned by: curtis
Priority: major Milestone: imagej2-b1-initial
Component: Legacy Compatibility Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking:

Description

Right now when user passes a Dataset to LegacyPlugin that cannot be repesented in IJ1 LegacyPlugin generates a Log.error(). It also Log.error()'s when an IJ1 plugin throws an exception. From within Eclipse at least these errors are never brought to the user's attention but just dumped to the console. Make IJ2 gracefully notify user of such problems.

I have left a stub failure generator commented out in LegacyPlugin::run(). This can be used to test our error handling improvement when it is in place.

Curtis, since you've worked on the logging I'm assigning to you. Comment and assign back if necessary.

Change History

comment:1 Changed 8 years ago by bdezonia

  • Milestone changed from imagej-2.0-beta2 to imagej-2.0-beta1

In b99cf0649a73ae68fa77e9a69e20fcf758987c0c & 0aaecd443e457cf8abaf78730e3931f6408ec231 I added code to notify user by using the ui agnostic prompt code that Grant wrote. This required adding a dependency upon ij-ui in the legacy subproject. Curtis please review and if this satisfactory close the ticket.

comment:2 follow-up: ↓ 3 Changed 8 years ago by curtis

  • Status changed from new to closed
  • Resolution set to fixed

I tweaked a bit in 7ce554b52a3425ac7608e115e0afdb77e53f47c4, but it looks good!

comment:3 in reply to: ↑ 2 Changed 8 years ago by curtis

Replying to curtis:

I tweaked a bit in 7ce554b52a3425ac7608e115e0afdb77e53f47c4, but it looks good!

Oops, I meant 94a205dd9e1a3bd88bc318844694f20f3d9df7da.

Note: See TracTickets for help on using tickets.