Ticket #796 (closed defect: wontfix)

Opened 6 years ago

Last modified 3 years ago

Brightness/Contrast "auto" works differently than IJ1

Reported by: afraser Owned by: curtis
Priority: minor Milestone: imagej2-b8-analysis
Component: Legacy Compatibility Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1100

Description

The "auto" contrast feature in IJ2's legacy implementation of Brightness/Contrast doesn't use the same function as IJ2.

Seems to be using min, max scaling as opposed to pretty-good scaling which allows a small percent of pixels to become saturated.

Change History

comment:1 Changed 6 years ago by afraser

  • Owner changed from curtis to afraser
  • Status changed from new to assigned

comment:2 Changed 6 years ago by afraser

  • Owner changed from afraser to curtis

The IJ1 auto-scaling logic has been implemented (almost exactly) in the new IJ2 auto-contrast plugin.

comment:3 Changed 6 years ago by curtis

  • Owner changed from curtis to gharris

comment:4 Changed 6 years ago by gharris

Committed r4627m which fixed the bug where the sliders were not set to their initial values by adding syncSliders() to constructor in SwingNumberWidget.
Next step is to make the B & C values go from -100 to +100 (not 0 to 255).

comment:5 Changed 6 years ago by curtis

  • Owner changed from gharris to curtis

comment:6 Changed 6 years ago by curtis

  • Milestone changed from imagej-2.0-beta1 to imagej-2.0-beta2

comment:7 Changed 5 years ago by curtis

  • Blocking 1100 added

comment:8 Changed 5 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta4

comment:9 Changed 5 years ago by curtis

  • Priority changed from major to minor

comment:10 Changed 5 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta5

comment:11 Changed 5 years ago by bdezonia

We need to make the interactive B&C command call plugins to accomplish it's tasks. We could make the Auto button call an AutoMinMax command of some sort that takes a double param for percent to exclude or some such. The B&C command would determine the percents to pass to the plugin. It would duplicate IJ1's wrapping behavior on multiple clicks of the Auto button. It might not use EnhanceConstrast though. But we can try to grab as much IJ1 code as possible.

comment:12 Changed 4 years ago by bdezonia

  • Milestone changed from imagej2-b7-ndim-data to imagej2-b8-analysis

comment:13 Changed 3 years ago by curtis

  • Status changed from assigned to closed
  • Resolution set to wontfix

ImageJ 1.x command ports to ImageJ2 are on hold until the ImageJ2 data structures can benefit from another design iteration. See  https://github.com/imagej/imagej-common/labels/data-model for a (non-comprehensive) list.

Note: See TracTickets for help on using tickets.