Ticket #663 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Refactor some display hierarchy code

Reported by: bdezonia Owned by: gharris
Priority: major Milestone: imagej-2.0-alpha5
Component: Display API Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking:

Description

We should push code from the various Display implementations into AbstractDisplay as much as possible. An AbstractDisplay could have a canvas and a window and getters. Implementors could narrow those types as needed. The window and canvas are set via initialization to super() as needed.

We could also take some code from AbstractDisplay and hatch AbstractPlanarDisplay. Update all implementors of Display to use one or the other of these two classes as its base.

Change History

comment:1 Changed 8 years ago by bdezonia

  • Summary changed from Refactor some display hierarcy code to Refactor some display hierarchy code

comment:2 Changed 8 years ago by bdezonia

Initial simple attempt was to push ImageCanvas into AbstractDisplay. However SwingImageDisplay allocates its canvas passing a reference of "this" which can't be passed to super().

comment:3 Changed 8 years ago by bdezonia

  • Milestone changed from biweekly-2011: Jul-18 to Jul-29 to imagej-2.0-alpha5

comment:4 Changed 8 years ago by bdezonia

  • Owner changed from bdezonia to curtis
  • Status changed from new to assigned

comment:5 Changed 8 years ago by bdezonia

Curtis, this may be best handled by you when the display redesign shakes out

comment:6 Changed 8 years ago by curtis

  • Owner changed from curtis to gharris

comment:7 Changed 8 years ago by gharris

  • Status changed from assigned to closed
  • Resolution set to fixed

Closed, See #730

Note: See TracTickets for help on using tickets.