Ticket #595 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Resolve Display Names and Window Menu Updates

Reported by: gharris Owned by: gharris
Priority: major Milestone: biweekly-2011: Jun-20 to Jul-01
Component: Display API Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking:

Description

We need a way to name Displays and update the Window Menu to reflect the open displays/windows.

This is related to #579

Displays do not themselves have names - currently a SwingDisplayWindow is titled with the Dataset.name (plus zoom factor) by makeTitle().

Since there can be more than one Display for a Dataset (yes?), we need a human readable (unique) name for each display.

In SwingDisplayWindow.redoLayout(), it says:
NOTICE single title set over and over with different Datasets

(I think that currently it would also change the name of the Display if you change the selected DisplayView.)

Window menu does not yet show the Displays - in order for it to do this, it would need some identifier that doesn't change, preferably unique.

We need some sort of DisplayWindowListener...
Pass a reference to the WindowsMenu to it and have it refresh the menu on add/delete displays. (Could we extend the DisplayManager for this purpose?)

How do we get ahold of the Window menu? It is coming from the ShadowMenu from IJ1 pluginFinder.

Change History

comment:1 Changed 8 years ago by gharris

  • Status changed from new to closed
  • Resolution set to fixed

Added Display Naming:

Moved Event.publish(new DisplayCreatedEvent) from SwingImageDisplay to DisplayPostProcessor.displayDataset

Made Display extend Named.
SwingImageDisplay get/setName() added.

SwingImageWindow is titled with the name of the SwingImageDisplay which is the dataset.name.

DisplayManager assures unique name/id. isUniqueName(), If not, appends ā€œ-nā€ to the name.

Zoom scale is shown in label, not title.

Window Menu Updates remain to do, new ticket #632 addresses this.

Note: See TracTickets for help on using tickets.