Ticket #547 (closed task: fixed)

Opened 8 years ago

Last modified 6 years ago

Make pure IJ2 Revert plugin

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b2-bugfixes
Component: Core Version:
Severity: serious Keywords:
Cc: Blocked By: #1045
Blocking: #1171

Description (last modified by bdezonia) (diff)

Due to limitations laid out in bug #531 and bug #528 we need a pure IJ2 implementation of File::Revert. There is a skeleton implementation still in IJ2 as of 90fcdf5996c97a17ed65a096a31cebb4a50f095d. It is a core plugin called RevertImage. Flesh this skeleton out.

Change History

comment:1 Changed 7 years ago by bdezonia

  • Milestone changed from imagej-2.0-beta1 to imagej-2.0-beta2

comment:2 Changed 7 years ago by bdezonia

We should store image source as a string if it's a file name or URL name. Revert plugin can find original source and if its available then pass it to ImgOpener. ImgOpener would need to handle URLs too.

Note that some images cannot be reverted. For instance an image created by running a plugin.

comment:3 Changed 7 years ago by curtis

  • Blocking 1019 added

comment:4 Changed 7 years ago by curtis

  • Blocked By 1045 added

comment:5 Changed 7 years ago by curtis

  • Status changed from new to closed
  • Resolution set to fixed

Done in 879e1d002ba5b3227bec751b6c5e17e0e3ce1821, though it opens a new window at the moment.

comment:6 Changed 7 years ago by bdezonia

  • Blocking 1171 added; 1019 removed

comment:7 Changed 7 years ago by bdezonia

  • Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta2

comment:8 Changed 6 years ago by bdezonia

  • Description modified (diff)

No longer seems to open a new window on revert.

Note that there are still problems. Since revert only reverts images that come from file (or URLSs???) it can't do things like revert a sample image to its original state.

I think what we really need here is for revert to do an undo all (at least if the image does not have a file/url source). This will need to wait until the undo code is in place.

Note: See TracTickets for help on using tickets.