Ticket #358 (closed task: fixed)

Opened 8 years ago

Last modified 6 years ago

Work on keystroke acceleration for IJ2

Reported by: bdezonia Owned by: curtis
Priority: major Milestone: imagej-2.0.0
Component: UI Framework Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking:

Description

Figure out how to get keyboard accelerators to work in IJ2. Implement in Swing and AWT UI's. Learn from IJ1 as appropriate.

Change History

comment:1 Changed 8 years ago by bdezonia

  • Status changed from new to accepted

comment:2 Changed 8 years ago by bdezonia

Determined the correct syntax to use in plugins. Implemented these changes in current plugins. Changed code in IJ2 to support Command/Control differences for Mac/other OSes. Allow X as shortcut for "control X" in plugin accelerator definitions.

comment:3 Changed 8 years ago by bdezonia

TODO - learn how to put accelerators in AWT menus and then implement for out AWT UI. Pretty sure code can be stolen from IJ1. Come up with UI agnostic way to support adding menu accelerators and then use in AWT & Swing UIs.

comment:4 Changed 8 years ago by bdezonia

note - if this will take more than a few hours push to another milestone

comment:5 Changed 8 years ago by bdezonia

Implemented an Accelerator class in AWTMenuCreator that enables keystroke accelerators in the AWT UI. This class is large and does not support all uniocde or non-QWERTY keyboard layouts. (The QWERTY issue arises because there is no KeyStroke key code for some characters such as question mark). It does however avoid a Swing dependency. The Accelerator class should be moved to its own class. But maybe we should retire it completely and require the AWT UI to have a Swing dependency. If we run into systems that have AWT and not Swing we'll address this issue at that time.

comment:6 Changed 8 years ago by bdezonia

  • Milestone changed from biweekly-2011: Mar-14 to Mar-25 to imagej-2.0-final

comment:7 Changed 7 years ago by curtis

Our recent work on the AcceleratorHandler global tool may be of use for supporting accelerators in the pure AWT implementation.

comment:8 Changed 6 years ago by bdezonia

  • Owner changed from bdezonia to curtis
  • Status changed from accepted to assigned

I believe this ticket is resolved. Curtis please review. Note this ticket is unclassified at the moment.

comment:9 Changed 6 years ago by curtis

  • Status changed from assigned to closed
  • Resolution set to fixed

Yep, this work is complete!

Note: See TracTickets for help on using tickets.