Ticket #1935 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Brightness/Contrast line display different than IJ1

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b8-analysis
Component: Analysis Plugins Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1100

Description

On the bc-histogram branch there is an implementation of the display of the slope/intercept trend line in the Brightness/Contrast command. It seems to work. However it does not display in the exact position that IJ1's does. Also contrast adjustment changes the trend line differently than IJ1. This may be that we have a different B&C algorithm. Or it may be that I've just implemented it incorrectly. Investigate and fix if necessary. (BTW note that IJ2 draws a slope line of 1 when default button is shown but note that histogram window is not square so we may need to stretch the space by the window aspect ratio).

Change History

comment:1 Changed 6 years ago by bdezonia

On the branch I adopted IJ1's line drawing approach. The aspect ratio issue is corrected by this and I consider trend line drawing correct now.

However the B/C adjustment code moves the trend line differently than IJ1. This is most apparent by cranking either brightness or contrast near full on and then adjusting the opposite. Compare to IJ1 under similar circumstances.

This is likely related to comments by Gabriel Landini in other B&C tickets (see children of my parent #1100). This ticket is likely complete once bc-histogram is merged to master.

comment:2 Changed 6 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed

Merged. Closing.

Note: See TracTickets for help on using tickets.