Ticket #1836 (closed defect: moved)

Opened 6 years ago

LegacyService dispose code is fragile

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b8-analysis
Component: Legacy Compatibility Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1459

Description

The DefaultLegacyService dispose() method closes all windows before shutting down IJ1. However the code that closes all windows can fail. You can see this by inspecting IJ1's source code. The closeAllWindows() command relies on the idea that Editor windows with changes will not close without saving first. Right now if a legacy plugin opens a Editor window and changes its text then the closeAllWindows() should fail. We might need some CodeHacker or reflection code for setting Editor's changed flag to false.

Change History

comment:1 Changed 5 years ago by curtis

  • Status changed from new to closed
  • Resolution set to moved
Note: See TracTickets for help on using tickets.