Ticket #1675 (closed defect: fixed)

Opened 7 years ago

Last modified 6 years ago

IOService enhancement needed for drag and drop

Reported by: bdezonia Owned by: curtis
Priority: major Milestone: imagej2-b7-ndim-data
Component: I/O Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #860

Description (last modified by bdezonia) (diff)

The drag and drop code (on drag-and-drop branch) treats all Files unclaimed by any handler as an image. This can result in exception errors. Ideally the ImageFileDragAndDropHandler would ask the IOService if the given file is an image file before accepting it. The IOService would need to be able to figure this out in a timely fashion. Maybe just by file extension. The service could have a default mode (extension checking only) and a thorough mode (try opening file and reading header if needed).

Change History

comment:1 Changed 7 years ago by bdezonia

  • Description modified (diff)

comment:2 Changed 6 years ago by bdezonia

  • Blocking 1712 added

comment:3 Changed 6 years ago by bdezonia

  • Owner changed from hinerm to curtis
  • Status changed from new to reviewing

ctrueden is working on DND and this problem right now. assigning to him.

comment:4 Changed 6 years ago by bdezonia

  • Milestone changed from imagej2-unscheduled to imagej2-b7-ndim-data

comment:5 Changed 6 years ago by bdezonia

  • Blocking 860 added; 1712 removed

comment:6 Changed 6 years ago by curtis

  • Status changed from reviewing to accepted

This is done on the  drag-and-drop branch. (Specifically, it is addressed in commit 4fef79c0.) When that branch is merged, I will close this ticket. There are still a few bugs to iron out first, though.

comment:7 Changed 6 years ago by curtis

  • Status changed from accepted to closed
  • Resolution set to fixed

Branch merged in 9f20b3ec.

Note: See TracTickets for help on using tickets.