Ticket #1656 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Simplify updater tests

Reported by: dscho Owned by: dscho
Priority: major Milestone: imagej2-b7-ndim-data
Component: Updater Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1901


The updater unit tests are horribly complicated. Most of them, however, could be simplified dramatically by using the command-line updater instead.

Change History

comment:1 Changed 7 years ago by bdezonia

  • Milestone set to imagej2-b8-analysis

comment:2 Changed 7 years ago by dscho

Progress was made in conjunction with implementing the WebDAV uploader backend: 822c1ccff054ddfe582a73f25873afe52a4108cc

comment:3 Changed 7 years ago by dscho

  • Status changed from new to closed
  • Resolution set to fixed

Further simplifications will be done on the fly. The new  https://github.com/imagej/imagej/blob/master/core/updater/src/test/java/imagej/updater/core/CommandLineUpdaterTest.java class contains much more intuitive ways to implement tests, so new tests will be added there, using the command-line updater, rather than extending  https://github.com/imagej/imagej/blob/master/core/updater/src/test/java/imagej/updater/core/UpdaterTest.java.

If need be, overly complicated tests will be reimplemented in CommandLineUpdaterTest and removed from UpdaterTest. I'd rather do that only if absolutely needed, though.

Last edited 7 years ago by dscho (previous) (diff)

comment:4 Changed 7 years ago by bdezonia

  • Blocking 1901 added; 1347 removed

comment:5 Changed 7 years ago by bdezonia

  • Milestone changed from imagej2-b8-analysis to imagej2-b7-ndim-data
Note: See TracTickets for help on using tickets.