Ticket #1639 (closed defect: fixed)

Opened 7 years ago

Last modified 6 years ago

Lurking issue with axes

Reported by: bdezonia Owned by: curtis
Priority: major Milestone: imagej2-b8-analysis
Component: ImgLib2 Version:
Severity: serious Keywords:
Cc: curtis Blocked By:
Blocking: #1923

Description

Currently Imglib's ImgPlus class has a getAxisIndex(AxisType) signature. This signature implies that each axis type can only be represented once in an ImgPlus. For many types this makes sense. But I can see cases where it would not (for instance if the ImgPlus wants to have two or more axes of UNKNOWN type). Maybe we need to revisit these assumptions.

Change History

comment:1 Changed 7 years ago by curtis

I think the method should simply document that it returns the index of the *first* axis of that type. Because as you say, it is often useful to be able to ask for e.g. the X axis.

comment:2 Changed 7 years ago by bdezonia

  • Blocked By 822 added
  • Milestone changed from imagej2-unscheduled to imagej2-b7-ndim-data

comment:3 Changed 7 years ago by bdezonia

  • Blocking 1398 added

comment:4 Changed 6 years ago by bdezonia

  • Blocking 1519 added; 1398 removed

comment:5 Changed 6 years ago by bdezonia

  • Milestone changed from imagej2-b7-ndim-data to imagej2-b8-analysis

comment:6 Changed 6 years ago by bdezonia

  • Blocking 1923 added; 1519 removed

ctrueden has ideas on how this should work for beta 8

comment:7 Changed 6 years ago by bdezonia

  • Owner changed from bdezonia to curtis
  • Status changed from new to assigned

ctrueden, I think you are fixing this in the img-metadata branch. assigning to you.

comment:8 Changed 6 years ago by curtis

Yep, it is already fixed on that branch. Each "unknown" axis uses a unique AxisType; the net.imglib2.meta.Axes class has an unknown() method that returns a new instance, ensuring that two "unknown" axis types are never equal.

When I finally merge that branch we will be able to close this ticket.

comment:9 Changed 6 years ago by bdezonia

  • Blocked By 822 removed

Fixed with imglib merge commit  e4e26aa05e0f42ff1a90e8c6d67235431471de44

comment:10 Changed 6 years ago by bdezonia

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.