Ticket #1603 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Updater does not support reinstating previously obsolete files

Reported by: curtis Owned by: dscho
Priority: critical Milestone: imagej2-b7-ndim-data
Component: Updater Version:
Severity: fatal Keywords:
Cc: Blocked By:
Blocking: #1901

Description

Attempting to reinstate (i.e., upload) a JAR that was previously marked as obsolete results in an exception:

java.lang.NullPointerException
	at imagej.updater.core.FileObject.setAction(FileObject.java:426)
	at imagej.updater.gui.FileTable.setFileAction(FileTable.java:380)
	at imagej.updater.gui.FileTable$3.actionPerformed(FileTable.java:221)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028)

The immediate issue is that current is null, so calling current.filename = ... does not work. But just wrapping this call in an if (current != null) test is insufficient to fully address this issue. The status label reports "upload: 1 (-1B)" and when clicking the "Upload" button there is an error dialog: "Obsolete file jars/scifio-devel-4.5-SNAPSHOT.jarhas dependencies: jars/slf4j-api.jar!" So it seems more care is needed to fully address this limitation.

Change History

comment:1 Changed 6 years ago by curtis

  • Blocking 1347 added

comment:2 Changed 6 years ago by curtis

  • Milestone changed from imagej2-b6-legacy to imagej2-b7-ndim-data

comment:3 Changed 6 years ago by dscho

  • Status changed from new to closed
  • Resolution set to fixed

Fixed as of 17c1a1e989318884014bcefe51dcdd119cbb8e9b

comment:4 Changed 6 years ago by bdezonia

  • Blocking 1901 added; 1347 removed
Note: See TracTickets for help on using tickets.