Ticket #1590 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Refactor the legacy result table sync code

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b6-legacy
Component: Legacy Compatibility Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1579

Description

On the first pass the code responsible for synchronizing the legacy results table was placed in LegacyCoimmand. The code there should be broken out into it's own class or service. This might be useful API for others to use. Note the existing implementation also relies on the singleton nature of the Analyzer's results table. Maybe some thought has to be given to how to support multiple LegacyCommands running at the same time.

Change History

comment:1 Changed 7 years ago by bdezonia

  • Blocking 1579 added

comment:2 Changed 7 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed

With commit 1d1d31a8cfff14c4af580380b41ffde4f18750e4 the code was refactored to break out a ResultsTableHarmonizer class.

After discussion with Curtis it was decided that we need not worry much about the effect of running multiple LegacyCommands simulataneously in regards to ResultsTable output. IJ1 also has this limitation and thus IJ2 is not making things worse.

Note: See TracTickets for help on using tickets.