Ticket #1470 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Eliminate bogus extra polygon tool

Reported by: curtis Owned by: curtis
Priority: major Milestone: imagej2-b6-legacy
Component: Tools Version: 2.0.0-beta4
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1574

Description

There is a grayed out polygon tool next to the working polygon tool on the Swing toolbar. It was put there as a workaround to another issue, but of course we need to eliminate it.

Change History

comment:1 Changed 7 years ago by curtis

One way to fix it would be to add a "visible" flag to the @Plugin annotation (I want to do this anyway) but I question whether we really need to have this tool at all. Is the problem due to the conflation of ImageJ Tools with JHotDraw adapters? If so, another solution could be to split the logic of those two things into two separate classes, with JHotDrawAdapter no longer extending Tool.

comment:2 Changed 7 years ago by dscho

  • Status changed from new to assigned

We need to merge the two. In other words, we cannot use the IJBezierTool as-is, because it would not allow us to add handling for subtracting a new polygon/Bézier from the current composite ROI using the Alt key.

comment:3 Changed 7 years ago by dscho

  • Blocking 878 added

comment:4 Changed 7 years ago by bdezonia

  • Blocking 878 removed
  • Milestone changed from imagej2-b7-ndim-data to imagej2-b6-legacy-undo

comment:5 Changed 7 years ago by bdezonia

  • Blocking 1574 added; 1358 removed

comment:6 Changed 7 years ago by bdezonia

  • Owner changed from dscho to curtis

comment:7 Changed 7 years ago by bdezonia

  • Status changed from assigned to closed
  • Resolution set to fixed

comment:8 Changed 7 years ago by curtis

Fixed in e0ce52d5.

Note: See TracTickets for help on using tickets.