Ticket #1416 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Cannot take a composite view to grayscale data via type change

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b4-plugins
Component: Plugins Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1333

Description

Right now if you load a multichannel image (neuron for instance), use the Channels Tool to make the view composite, and then type change to something else the data is not a single channel grayscale composite image but a multichannel noncomposite image. It would be nice if somehow the user could take a composite view to a grayscale image.

However right now TypeChanger works with Datasets. And thats nice because it has no reliance on the UI classes. If we can allow a user to change the composite channel count of a Dataset (i.e. a Make Composite plugin) then user can get a grayscale from any Dataset. But having Make COmposite and also Channels Tool :: Composite may be confusing. Think about this some more.

Change History

comment:1 Changed 7 years ago by bdezonia

  • Blocking 1333 added

comment:2 Changed 7 years ago by bdezonia

Curtis and Barry agree that setting the Dataset's composite channel count isn't robust. It's meant to track what the data source provided. And since there are possibly multiple DatasetViews per Dataset changing it would affect multiple windows.

Some discussion was made to have DatasetView have a separate tracking of composite channel count. And having the type changer work from a DatasetView. We could have multiple translation layers (i.e. type change a Dataset or type change a DatasetView)

comment:3 Changed 7 years ago by bdezonia

Note that as implemented now a merged dataset always goes to a grayscale composite image. We have now lost the ability to have multichannel grayscale image as a result of a type change. We need to distinguish on the view's isComposite() flag to decide whether to translate to grayscale composite or grayscale multichannel.

comment:4 Changed 7 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed

With commit 6f37d506f9804a7e4eb53896852df2cb238dd7d8 the type changing code now makes it composite gray image if Image :: Colors :: Channels Tool shows mode to be Composite. Otherwise it makes a multichannel gray image.

Note: See TracTickets for help on using tickets.