Ticket #1362 (closed enhancement: fixed)

Opened 7 years ago

Last modified 7 years ago

Updater: re-implement the "Show changes" button from the Fiji Updater

Reported by: dscho Owned by: dscho
Priority: major Milestone: imagej2-b4-plugins
Component: Core Version:
Severity: major Keywords:
Cc: Blocked By:
Blocking: #1454

Description

Fiji had the "Show changes" button in the updater which allowed the uploader to determine what changed and whether it was safe to upload.

However, Fiji did it by detecting whether the Script Editor was present and having some updater-specific code in the Script Editor. This was due to the Script Editor already having dependencies on the Fiji Build System which was used to determine the source paths corresponding to the component in question.

Let's re-implement that functionality without incurring the same amount of technical debt by relying on the Git executable instead. That is, if git (or git.exe) are in the PATH, add the button, and try to determine the source path using git ls-files instead, using ByteCodeAnalyzer's ability to determine the source file and the package name of a class given its bytecode.

Change History

comment:1 Changed 7 years ago by dscho

  • Status changed from new to closed
  • Resolution set to fixed

The initial version of the code was finalized in a7f6dea0555d3b378f15b287d8b2ac5bfd58ece9.

comment:2 Changed 7 years ago by dscho

  • Blocking 1454 added

comment:3 Changed 7 years ago by dscho

  • Blocking 1347 removed
Note: See TracTickets for help on using tickets.