Ticket #1296 (closed defect: fixed)

Opened 7 years ago

Last modified 6 years ago

Image > Stacks > Label not quite working

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b6-legacy
Component: Data Model Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1574

Description

The Image > Stacks > Label command works fine with default dialog values. However if the "use overlay" checkbox is enabled then the resulting image has no labels. This is because we do not yet have a TextOverlay type. We must add it and translate them between IJ1's version in OverlayHarmonizer.

Change History

comment:1 Changed 7 years ago by bdezonia

  • Component changed from ij-core to ij-data-model

comment:2 Changed 7 years ago by bdezonia

  • Blocked By 1331 added

comment:3 Changed 7 years ago by bdezonia

  • Blocking 1331 added
  • Blocked By 1331 removed

comment:4 Changed 7 years ago by bdezonia

  • Blocking 1459 added; 1331 removed
  • Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta5

comment:5 Changed 6 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from imagej-2.0.0-beta7 to imagej-2.0.0-beta6

With commit 07a3baed383e860d97c14c2aef7b5c171b6aa2f7 the label TextRois in the ImagePlus' overlay are now translated to TextOverlays. This class provides rudimentary translation support. Nothing is yet displayed but that and other issues wait to be addressed in a ticket I am adding immediately. Note that this change also fixes a bug in that previously the ImagePlus overlay was never translated to IJ2 overlays.

comment:6 Changed 6 years ago by bdezonia

  • Blocking 1574 added; 1459 removed

comment:7 Changed 6 years ago by bdezonia

There is another problem with the "Use Overlay" checkbox after this fix. While doing this fix the IJ1 Overlay associated with an ImagePlus is used for storing the nonactive Overlays of IJ2. Any plugin that messes with the Overlay can cause nonactive IJ2 ROIs to disappear. The Stack Label command is one such plugin when "Use Overlay" is selected.

comment:8 Changed 6 years ago by bdezonia

  • Blocked By 948, 1581 added

<incorrect text deleted>

Last edited 6 years ago by bdezonia (previous) (diff)

comment:9 Changed 6 years ago by bdezonia

  • Blocked By 948, 1581 removed
Note: See TracTickets for help on using tickets.