Ticket #1216 (closed defect: moved)

Opened 7 years ago

Last modified 7 years ago

DefaultDatasetView::autoscale() is inefficient and broken

Reported by: bdezonia Owned by: curtis
Priority: major Milestone: imagej-2.0.0
Component: Display API Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1170

Description

From a debugging session I see that sequential calls to DefaultDatasetView::autoscale() end up repeatedly computing the overall min and max. It could compute once and use cached results. Also it uses overall min and max rather than channel min and max which may be broken. Note too that Curtis has a TODO item listed saying autoscale() is wrong. We should revisit autoscaling.

Change History

comment:1 Changed 7 years ago by bdezonia

  • Blocking 1170 added

comment:2 Changed 7 years ago by bdezonia

  • Status changed from new to assigned
  • Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta6

comment:3 Changed 7 years ago by bdezonia

  • Milestone changed from imagej-2.0.0-beta6 to imagej-2.0.0

comment:4 Changed 7 years ago by bdezonia

Note at some point I added code to make sure autoscale() calcs min and max by channel correctly now.

comment:5 Changed 4 years ago by curtis

  • Status changed from assigned to closed
  • Resolution set to moved
Note: See TracTickets for help on using tickets.