Ticket #1201 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Implement overlay duplication by serialization

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b3-headless
Component: Data Model Version:
Severity: serious Keywords:
Cc: leek@… Blocked By:
Blocking: #1143

Description (last modified by bdezonia) (diff)

Recently a duplicate() functionality was added to Overlays. The implementation for this was left to each class to define. It turns out this works except for CompositeOverlay.

Lee recommends that duplication should be an operation that relies upon a serialize/deserialize step to/from memory from within AbstractOverlay::duplicate(). Other classes could override if needed (such as BinaryMaskOverlay) where efficiency might dictate another approach.

Change History

comment:1 Changed 7 years ago by bdezonia

I have some initial work done locally. It appears to get this working we'll need to make the Imglib RegionOfInterest classes implement Externalizable.

comment:2 Changed 7 years ago by bdezonia

  • Description modified (diff)

comment:3 Changed 7 years ago by bdezonia

  • Cc leek@… added

comment:4 Changed 7 years ago by bdezonia

I have at the moment avoided pushing Externalizable into Imglib by improving CompositeOverlay. The default implementation of duplicate() is in place and working.

CompositeOverlay needs to override some methods where it needs to composite results. This could be tricky. Must investigate.

comment:5 Changed 7 years ago by bdezonia

  • Blocking 1143 added

comment:6 Changed 7 years ago by bdezonia

The remaining issues with this ticket are tangential to the original problem. I have opened them as ticket #1268. The overlay duplication is mostly contained to IJ1. Closing.

comment:7 Changed 7 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.