Ticket #1146 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Math plugins don't handle merged color data correctly

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b2-bugfixes
Component: Plugins Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking:

Description

The math plugins modify values irregardless of channel. In IJ1 you can add a value to a color image and its intensity grows. In IJ2 each channel value is bumped and the displayed color changes. Further investigation into how math plugins should interact composite images is required.

For an example of the problem load clown and using Process > Math > Add to add 25. Compare results to IJ1.

Change History

comment:1 Changed 7 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed

It appears that IJ1 applies a math op to each channel of a color image. And it clamps out of bounds values.

With 24426a7270d9398cdc16b874bae1bb9d2c00c2ed I have mad sure all planes of color merged datasets are updated when necessary. And previews now restore all those channels too.

IJ2 still does not match IJ1 because Imglib does not clamp out of bounds data values. There is a separate ticket for that: #1129

Last edited 7 years ago by bdezonia (previous) (diff)

comment:2 Changed 7 years ago by bdezonia

  • Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta2
Note: See TracTickets for help on using tickets.