Ticket #1125 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Duplicate command does not respect selection

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b3-headless
Component: Plugins Version:
Severity: serious Keywords:
Cc: Blocked By:

Description (last modified by bdezonia) (diff)

After the beta1 release in the imagej list Leon Espinosa reported:

"Duplicate" command duplicates the whole image not only the selection.

Change History

comment:1 Changed 8 years ago by bdezonia

  • Description modified (diff)

comment:2 Changed 8 years ago by bdezonia

In 1084c35c388a3aee47f44c4de3d37fe52e81fde8 now only duplicating selected bounds.

In IJ1 the ROI from the original image is duplicated in the new image. That code is not yet in place in IJ2.

comment:3 Changed 8 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta2 to imagej-2.0.0-beta3

comment:4 Changed 8 years ago by bdezonia

We need to determine how we want to handle the duplication of ROIs. When user runs duplicate on a selected region the existing ROIs need to be duplicated and moved to new origin. I have done some play implementations. They all eventually reach the limitations of the Imglib RegionOfInterest definitions. One needs to define duplicate() and move() in the base classes. Note that move() will be broken for the Img-based BinaryMaskedRegionOfInterest. Using PointSets would simplify things here. Need further discussion with Imglib folks.

comment:5 Changed 8 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed

With commit 192365bdbc3b77c02b348bfb1be6e8c18e03705d an initial implementation of code that allows Overlays to be moved and duplicated is in place. It could be further frefined but we'll wait for discussions with others. Closing this ticket.

Note: See TracTickets for help on using tickets.