Ticket #1120 (closed task: fixed)

Opened 7 years ago

Last modified 7 years ago

Merge ij-options into other projects

Reported by: curtis Owned by: curtis
Priority: major Milestone: imagej2-b4-plugins
Component: Core Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1323

Description

The ij-options package has options for a variety of other components. It currently has a dependency on ij-data. It would make more sense for the options infrastructure itself to live in ij-core/ij-ext (see #994), and the options plugins to live next to the appropriate functionality, perhaps in core/plugins/options or divided amongst the existing core plugins projects.

Note: most (but not all) of the options plugins need to be accessible from ij-legacy, to keep the values properly synced with IJ1.

Merging the ij-options infrastructure into ij-core will allow the static Prefs class to be wrapped into the OptionsService.

Change History

comment:1 Changed 7 years ago by curtis

The OptionsService has moved to ij-core as of 44baa93f.

Some options plugins (OptionsChannels and OptionsOverlay) depend on ij-data, so those moved to ij-data as of 9802a1de.

All that remains is to divvy up the remaining options plugins to their proper components... though we should carefully consider where each options plugin should live.

comment:2 Changed 7 years ago by curtis

  • Blocking 1209 added

comment:3 Changed 7 years ago by curtis

  • Blocking 1323 added

comment:4 Changed 7 years ago by curtis

  • Blocking 1209 removed
  • Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta4

comment:5 Changed 7 years ago by curtis

After further review, I do not think it makes sense to divide up the options as described above. It is easier to keep them in a central component "ij-options" for core options with package name imagej.core.options, similar to how ij-plugins-*, ij-tools and ij-platforms are structured. This was done in d89ff941 and 8b69522e.

The only task remaining is to evaluate whether to update imagej.util.Prefs, perhaps merging with the OptionsService or at least moving to the imagej.options package.

comment:6 Changed 7 years ago by curtis

  • Status changed from new to closed
  • Resolution set to fixed

I have filed a new ticket #1451 for the options/prefs/config consolidation. This ticket is closed.

Note: See TracTickets for help on using tickets.