Ticket #1119 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

ImgPlus::validateAxes() may be too lax

Reported by: bdezonia Owned by: curtis
Priority: major Milestone: imagej2-b6-legacy
Component: Data Model Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1572

Description

In implementing code I ran across the following problem with axis validation. If you create a 3 channel unsigned byte dataset but only specify two axes (X & Y) it can display poorly. Once you've created the dataset set it's merged flag true. Code that displays it may show it as grayscale. The last axis (which we want to be channel) is recorded as UNKNOWN. Maybe ImgPlus::validateAxes() should accept null or num axes == num dims. Or complain more loudly. Otherwise its a hard to debug error. (One could define a merged color dataset creator that would avoid these problems but plugin developers might run into the same problem).

Change History

comment:1 Changed 7 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta4

comment:2 Changed 7 years ago by dscho

  • Blocking 1349 added

comment:3 Changed 7 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta5

comment:4 Changed 7 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed
  • Component changed from imglib to ij-data-model

With commit ebcd6c046d807652b18ac1dea6e5499fcdd01c3b i added validation code to DefaultDataset::setRGBMerged() which should keep this issue from arising.

comment:5 Changed 7 years ago by bdezonia

  • Blocking 1572 added; 1349 removed

comment:6 Changed 7 years ago by bdezonia

  • Milestone changed from imagej-2.0.0-beta7 to imagej-2.0.0-beta6
Note: See TracTickets for help on using tickets.