Ticket #1103 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Point Rois do not display

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b6-legacy
Component: Legacy Compatibility Version:
Severity: serious Keywords:
Cc: sapristi@…, curtis Blocked By:
Blocking: #1583

Description

Albert Cardona reported in the imagej devel mailing list:

point rois don't show.

  1. Open the blobs sample image
  2. Run "Process - Find Maxima"
  3. Tick the preview checkbox: no point roi shows
  4. Push ok: no point roi shows.

Change History

comment:1 Changed 7 years ago by bdezonia

  • Cc curtis added

With a82a9c3e37743ca49028ca26a3d114ff4eda876d multipoint IJ1 PointRois are translated to multiple IJ2 PointOverlays.

In the short term this works but is slow.

One possible fix: we streamline the overlay addition mechanism to add multiple overlays with a single display update call.

Another possible fix: extend our PointRoi class and related JHotDraw classes to support multipoint sets. Then add a single overlay.

comment:2 Changed 7 years ago by curtis

  • Blocking 1143 added

comment:3 Changed 7 years ago by bdezonia

  • Blocking 285 added

comment:4 Changed 7 years ago by bdezonia

  • Blocking 1143 removed

comment:5 Changed 7 years ago by bdezonia

  • Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta4

comment:6 Changed 7 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta6

ROIs will be the focus of beta6.

comment:7 Changed 7 years ago by bdezonia

Note as detailed in ticket #1478 the slow response is due to the fact that each overlay added to the display forces a rebuild/redraw sequence (which has its own ticket too).

comment:8 Changed 7 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from imagej2-b9-rois to imagej2-b6-legacy-undo

Decided to take the approach of allowing PointOverlay to store multiple points. With commit b13a45eb8ea6992aecd65951a0c3fd73c9e95acd this bug is fixed.

comment:9 Changed 7 years ago by bdezonia

  • Blocking 1583 added; 285 removed
Note: See TracTickets for help on using tickets.