Ticket #1100 (assigned feature)

Opened 7 years ago

Last modified 5 years ago

Improve Brightness and Contrast functionality [analysis]

Reported by: bdezonia Owned by: curtis
Priority: minor Milestone: imagej2-b8-analysis
Component: Display API Version: 2.0.0-beta6
Severity: serious Keywords:
Cc: G.Landini@…, Michael.Cammer@… Blocked By: #796, #1099, #1316, #1613, #1800, #1801, #1802, #1803, #1809, #1932, #1935
Blocking:

Description (last modified by curtis) (diff)

In the imagej devel maling list Gabriel Landini noted the following issues with the Brightness/Contrast plugin:

  1. I can't do anything else until I close the dialog. For example, IJ2 does not report pixel the values under the cursor until the brightness dialog is closed. Is that how it is planned to work?
  1. Dialog needs "reset" and "apply" buttons.
  1. Minimum and maximum return fractional values for an 8 bit LUT. Is that right?
  1. Are the Brightness and Contrast values (0-100?) the best scale resolution to use?. I think that having 100 units controlling LUTs with 256 values at least for 8 bit images will create unnecessary hassle (like the fractional values mentioned above). I can't see any advantage on 0-100 vs 0-255 (but maybe there is some reason?).
  1. Compare Contrast in IJ1 with IJ2. In IJ2 the contrast does not respect the brightness, as (without any brightness tweaking) the contrast should narrow the LUT to 127 or so. Currently IJ2 at 100 setting of contrast has a minimum of 0 and a maximum of 4.67 (?). I think contrast should control the width of the LUT from both sides, while keeping it centred. Currently it affects the max value and as a consequence it changes both the width and the position of the lut. So "Contrast" behaves same the "Maximum" slider of IJ1.
  1. Maybe Maximum and Minimum would be more useful having sliders too instead of number boxes.

Change History

comment:1 Changed 7 years ago by curtis

  • Type changed from defect to feature
  • Description modified (diff)
  • Summary changed from Brightness and Contrast dialog issues 2 to Brightness and Contrast improvements

comment:2 Changed 6 years ago by curtis

  • Blocked By 1099 added

comment:3 Changed 6 years ago by curtis

  • Blocked By 796 added

comment:4 Changed 6 years ago by bdezonia

  • Owner changed from curtis to bdezonia
  • Status changed from new to assigned

comment:5 Changed 6 years ago by bdezonia

  • Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta4

comment:6 Changed 6 years ago by bdezonia

  • Blocked By 1316 added

comment:7 Changed 6 years ago by curtis

  • Priority changed from major to minor
  • Summary changed from Brightness and Contrast improvements to Improve Brightness and Contrast functionality

I will try to address these brightness/contrast issues for beta4, but there are a lot of other high-priority items first.

comment:8 Changed 6 years ago by curtis

  • Owner changed from bdezonia to curtis

comment:9 Changed 6 years ago by bdezonia

Regarding point 5) above the requested contrast features seem to be available separately in the Window/Level plugin in IJ1. We also need to implement that code in IJ2 but we should make sure we are placing the correct functionality in each plugin.

comment:10 Changed 6 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta5

comment:11 Changed 6 years ago by curtis

  • Component changed from ij-plugins to ij-display

comment:12 Changed 6 years ago by curtis

  • Blocked By 1613 added

comment:13 Changed 6 years ago by curtis

  • Cc Michael.Cammer@… added
  • Version set to 2.0.0-beta6

Additional comments from Michael Cammer:

In ImageJ the B&C window floats.  In IJ2 it does not float.  We cannot
move through slices of a stack when the window is open.  It does not
show a histogram nor does it have sliders for min/max.

Also, the values displayed in the min/max bars have decimal values but
the images we have are 16 bit integer.

comment:14 Changed 6 years ago by bdezonia

  • Blocked By 1799 added

comment:15 Changed 6 years ago by bdezonia

  • Blocked By 1800 added

comment:16 Changed 6 years ago by bdezonia

  • Blocked By 1801 added

comment:17 Changed 6 years ago by bdezonia

  • Blocked By 1802 added

comment:18 Changed 6 years ago by bdezonia

  • Blocked By 1803 added

comment:19 Changed 6 years ago by bdezonia

This ticket is a feature ticket. Blocking tickets were hatched for all issues mentioned above. Please update those tickets as appropriate.

comment:20 Changed 6 years ago by bdezonia

  • Blocked By 1809 added

comment:21 Changed 6 years ago by bdezonia

  • Blocked By 1810 added

comment:22 Changed 5 years ago by bdezonia

  • Blocked By 1799 removed

comment:23 Changed 5 years ago by bdezonia

  • Blocked By 1810 removed

comment:24 Changed 5 years ago by bdezonia

  • Summary changed from Improve Brightness and Contrast functionality to Improve Brightness and Contrast functionality [analysis]
  • Milestone changed from imagej2-b7-ndim-data to imagej2-b8-analysis

comment:25 Changed 5 years ago by bdezonia

  • Blocked By 1932 added

comment:26 Changed 5 years ago by bdezonia

  • Blocked By 1935 added
Note: See TracTickets for help on using tickets.