Ticket #1099 (closed defect: fixed)

Opened 8 years ago

Last modified 6 years ago

Brightness and Contrast lacks a histogram

Reported by: bdezonia Owned by: bdezonia
Priority: minor Milestone: imagej2-b8-analysis
Component: Plugins Version:
Severity: serious Keywords:
Cc: sapristi@…, Michael.Cammer@… Blocked By:
Blocking: #1100

Description

In the imagej devel mainling list Albert Cardona noted the following about the Brightness/Contrast dialog:

  • lacks a histogram
  • moving the sliders feels jumpy
  • the image is refreshed either slow or not frequently enough, giving the appearance of a slow operation.

Change History

comment:1 Changed 8 years ago by bdezonia

  • Summary changed from Briaghtness and Contrast dialog issues to Brightness and Contrast dialog issues

comment:2 Changed 7 years ago by curtis

  • Blocking 1100 added

comment:3 Changed 7 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta4

comment:4 Changed 7 years ago by curtis

  • Priority changed from major to minor

comment:5 Changed 7 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta5

comment:6 Changed 7 years ago by bdezonia

  • Cc Michael.Cammer@… added

The performance issues have been hatched in their own ticket. See #1804.

The meat of this ticket now is that it lacks a histogram. This has also been mentioned by Michael Cammer

comment:7 Changed 7 years ago by bdezonia

We are waiting for the histograms branch of Imglib to be merged before proceeding. We'll need to make a Histogram input widget associated with an Imglib2 Histogram. Then image's Histogram can be computed by the plugin and displayed by the widget. The widget might need little more api than the ability to draw lines over the top of it. It might be desirable to use the chart returned by the HistogramPlot dialog (breaking that out into an ui agnostic charting package used by both plugins). There is such a ticket elsewhere.

comment:8 Changed 6 years ago by bdezonia

  • Milestone changed from imagej2-b7-ndim-data to imagej2-b8-analysis

comment:9 Changed 6 years ago by curtis

  • Owner changed from curtis to bdezonia
  • Status changed from new to assigned
  • Summary changed from Brightness and Contrast dialog issues to Brightness and Contrast lacks a histogram

The charting service ticket is #1117. It is not a priority for ImageJ 2.0.0, but soon after. Fortunately, to address this ticket we do not need a charting service. We only need a histogram widget that can be used when a command has a @Parameter histogram. Assigning this ticket to bdezonia, since better histograms is one of his projects.

comment:10 Changed 6 years ago by bdezonia

The HistogramWidget is done and merged to master. These widgets are created when you declare a HistogramBundle @Parameter in a Command implementation. The HistogramWidget is currently enableded in the Adjust Threshold and Histogram Plot commands. A HistogramBundle needs to be incorporated into the Brightness/Contrast plugin.

comment:11 Changed 6 years ago by bdezonia

On the bc-histogram branch is an implementation of B&C with a histogram included. It needs testing and perhaps enhancement before merging to master.

comment:12 Changed 6 years ago by bdezonia

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged. Closing.

Note: See TracTickets for help on using tickets.