Ticket #1095 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

ij-launcher project POM reports errors in Eclipse

Reported by: curtis Owned by: dscho
Priority: minor Milestone: imagej2-b2-bugfixes
Component: Build System Version:
Severity: minor Keywords:
Cc: Blocked By:
Blocking:

Description

The ij-launcher project uses the maven-nar-plugin with nar packaging, which unsurprisingly does not work with Eclipse's m2e plugin. Eclipse complains when importing the ij-launcher project, though it is still possible to work on the Java sources successfully.

To avoid this problem, I have pushed  a hack to the  launcher-eclipse-hack branch. Dscho, could you review and merge to master if you like it? It seems to work, but my concern is that once again it may complicate things for MiniMaven.

Change History

comment:1 follow-up: ↓ 2 Changed 7 years ago by dscho

Looks good, but I hoped that things would not be included by default due to ij-launcher being a dependency of pom-ij-core only when activating the 'launcher' profile?

comment:2 in reply to: ↑ 1 Changed 7 years ago by curtis

Replying to dscho:

I hoped that things would not be included by default due to ij-launcher being a dependency of pom-ij-core only when activating the 'launcher' profile?

Eclipse picks up all project modules, even those wrapped in inactive profiles. But even if it did not do so, it is still nice to be able to develop ij-launcher from within Eclipse (e.g., that is how I applied the formatting template).

comment:3 follow-up: ↓ 4 Changed 7 years ago by dscho

Okay. But if you do not mind, I would like to change the id from 'not-eclipse' to 'no-nar' so I can pick that up from MiniMaven. Okay?

comment:4 in reply to: ↑ 3 Changed 7 years ago by curtis

Replying to dscho:

Okay. But if you do not mind, I would like to change the id from 'not-eclipse' to 'no-nar' so I can pick that up from MiniMaven. Okay?

Sure, I force pushed the change.

comment:5 Changed 7 years ago by dscho

  • Status changed from new to closed
  • Resolution set to fixed

Curtis fixed this in bbcca3f6a27b675f63f5bf53193c62067fe0feab.

comment:6 Changed 7 years ago by bdezonia

  • Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta2
Note: See TracTickets for help on using tickets.