Ticket #1074 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Using prebuilt IJ2 jar the About ImageJ fails to load images

Reported by: bdezonia Owned by: curtis
Priority: major Milestone: imagej2-b1-initial
Component: Plugins Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking:

Description (last modified by bdezonia) (diff)

(original description)
Running IJ2 on Ubuntu 11. When you run About ImageJ it cannot load the default image and rather uses the stock 400x400 black image with yellow text. Determine why it can't load image.

(modification)
If you run IJ from within Eclipse and run ABout ImageJ background images are loaded and drawn over. If you run the jar downloaded from the website then the background images cannot be loaded and the about always shows a black image. Its as if the jar build differs between eclipse and our jenkins build scripts.

Change History

comment:1 Changed 8 years ago by bdezonia

Note also that the 400x400 image displays with white space on right. Not sure this is a scrollbar issue also. Noting here so that we make sure it is fixed. (Later edit - the image white space arises because the window is wide enough to show whole toolbar which is wider than the 400 x 400 default image in AboutImageJ).

I have tried to debug into code but could not get eclipse and the tool chain setup correctly. Will need to look at this later.

Last edited 8 years ago by bdezonia (previous) (diff)

comment:2 Changed 8 years ago by bdezonia

Recently made stock image 500x500. This should eliminate the whitespace issue.

comment:3 Changed 8 years ago by bdezonia

Note memory summary does not match status bar double click summary. Top end memory way off. (Later note: found issue and addressed)

Last edited 8 years ago by bdezonia (previous) (diff)

comment:4 Changed 8 years ago by bdezonia

  • Description modified (diff)
  • Summary changed from About ImageJ fails on Linux to Using prebuilt IJ2 jar the About ImageJ fails to load images

comment:5 Changed 8 years ago by bdezonia

  • Owner changed from bdezonia to curtis
  • Status changed from new to assigned

comment:6 Changed 8 years ago by bdezonia

  • Milestone changed from imagej-2.0-beta2 to imagej-2.0-beta1

comment:7 follow-up: ↓ 8 Changed 8 years ago by dscho

I implemented an idea in the ticket-1074 branch: moving the about/ folder to ui/app/src/main/assembly/application/ so that it will automatically be copied to the imagej2/ root in the application.zip. For debugging purposes, the About plugin looks first in <IJ>/about/ and falls back to the path mentioned above.

For good measure, that branch also contains a BSD-licensed random generator and uses it instead of java.util.Random.

Feel free to pick what you want, and to leave what you do not want :-)

comment:8 in reply to: ↑ 7 Changed 8 years ago by curtis

Replying to dscho:

I implemented an idea in the ticket-1074 branch: moving the about/ folder to ui/app/src/main/assembly/application/ so that it will automatically be copied to the imagej2/ root in the application.zip. For debugging purposes, the About plugin looks first in <IJ>/about/ and falls back to the path mentioned above.

Barry and I discussed your approach, but settled on instead updating the application.xml assembly descriptor to include the about/ folder off the root. In this way, no further changes beyond 8779c2142ffe12eb2b0b1d5d944aa3a4a54af73f are necessary to AboutImageJ.

I thought I had committed the changed application.xml already, but I guess not. It must be waiting to be pushed from my work machine. I will do so on Monday and close this ticket, once I verify that everything works in all cases.

For good measure, that branch also contains a BSD-licensed random generator and uses it instead of java.util.Random.

Are you convinced it is better than java.util.Random? If so, should we publish it as a standalone JAR in our Maven repository? I looked at the ticket-1074 branch, but did not see any use of a random number generator other than java.util.Random.

Last edited 8 years ago by curtis (previous) (diff)

comment:9 Changed 8 years ago by dscho

Oh, sorry, my mistake. I forgot to push (but since I set up my machine to be able to connect from home, I was able to push a minute ago).

Fair enough for the assembly approach, sorry that I just jumped in ;-)

comment:10 Changed 8 years ago by curtis

  • Status changed from assigned to closed
  • Resolution set to fixed

Commits 6a0e000a66883b6dbef9cb34c67cdea04e6ffb56, 8779c2142ffe12eb2b0b1d5d944aa3a4a54af73f and f3323a6109fa82d07abf0086cdb94eab87c5c2b3 address this issue.

Note: See TracTickets for help on using tickets.