Ticket #1067 (closed defect: fixed)

Opened 8 years ago

Last modified 7 years ago

Always update IJ1 with IJ2 colors

Reported by: bdezonia Owned by: bdezonia
Priority: major Milestone: imagej2-b4-plugins
Component: Core Version:
Severity: serious Keywords:
Cc: Blocked By:
Blocking: #1341

Description

The OptionsChannels plugin has a couple public methods that allow others to make a fg or bg color to be remembered by the dialog. This functionality is kind of key for legacy compatiblity. The PickerTool sets these when user clicks on a pixel.

A problem arises in that the legacy layer needs to synchronize colors whenever the OptionsChannels colors are updated. So right now the picker tells the OptionsChannels dialog what its EventService is and that event service gets an OptionsEvent generated that will eventually start legacy options synchronization. This works but is hacky.

Ideally, if anyone sets one of these colors in OptionsChannels we should generate the appropriate event. Thus OptionsChannels needs a way to track the current context. Right now the OptionsPlugins do not do this.

Change History

comment:1 Changed 8 years ago by bdezonia

  • Summary changed from Improve OptionsChannels plugin to Always update IJ1 with IJ2 colors

comment:2 Changed 7 years ago by bdezonia

  • Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta4

comment:3 Changed 7 years ago by bdezonia

  • Blocking 1341 added

comment:4 Changed 7 years ago by bdezonia

  • Status changed from new to closed
  • Resolution set to fixed

Most of this ticket had been handled previously. The event and context discussion was fixed recentlly by Curtis.

With commit b48302ce10ab1c5f9ba55b05271220b60917f444 the IJ2 colors are always propagated to IJ1 before plugin runs.

Closing this ticket.

Note: See TracTickets for help on using tickets.