Ticket #1041 (closed enhancement: fixed)

Opened 7 years ago

Last modified 6 years ago

Make Histogram implement ImgLib2 interfaces

Reported by: curtis Owned by: bdezonia
Priority: major Milestone: imagej2-b7-ndim-data
Component: ImgLib2 Version:
Severity: serious Keywords:
Cc: pietzsch@… Blocked By:
Blocking: #1203

Description

Histogram should not have an getHistogram() that returns an int[] array which represents the histogram. Rather, Histogram itself should represent the histogram. For example, it could implement RandomAccessibleInterval< IntType > to achieve that, and the histogram could be computed in the constructor.

Change History

comment:1 Changed 7 years ago by curtis

  • Blocking 1203 added

comment:2 Changed 7 years ago by curtis

  • Milestone changed from imagej-2.0.0 to imagej-2.0.0-beta4

comment:3 Changed 7 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta5

comment:4 Changed 7 years ago by aivar

  • Owner changed from curtis to aivar
  • Status changed from new to assigned

comment:5 Changed 7 years ago by curtis

  • Milestone changed from imagej-2.0.0-beta6 to imagej-2.0.0-beta7

comment:6 Changed 6 years ago by dscho

  • Milestone changed from imagej2-b8-analysis to imagej2-b7-ndim-data

Fixing ImageJ-tickets....

comment:7 Changed 6 years ago by bdezonia

  • Owner changed from aivar to curtis
  • Status changed from assigned to reviewing

There are now new histogram implementations in the imglib2 algroithms hsitogram package. Histogram does not implement the interval classes but it provides an accessor to the underlying DiscreteFrequencyDistribution. This distribution implements Img<LongType>. I believe this gives the desired functionality. Please review as necessary.

comment:8 Changed 6 years ago by bdezonia

  • Owner changed from curtis to bdezonia
  • Status changed from reviewing to accepted

With commit 4f60ee8ad4a14e0dfa4d6d44eeea5ed547a3f34c the histogram classes were made to implement Img<LongType>. Most of the support of this api is handled by delegation to the underlying DiscreteFrequencyDistribution.

comment:9 Changed 6 years ago by bdezonia

  • Status changed from accepted to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.